search

ktwrd / beans-rs

Open-Source Installer for Sourcemods
GNU General Public License v3.0
7 stars 1 forks source link

Repalce native-dialog with fltk #19

Closed ktwrd closed 3 months ago

ktwrd commented 4 months ago

This PR replaces the usage of the crate native-dialog with fltk. This should make it a bit more stable on some systems, and less likely to fail.

Most of the logic for the dialog box (and fltk's dependencies) are copied from PR #6.

Important Note

This will move the develop branch back to using x86_64-unknown-linux-gnu instead of x86_64-unknown-linux-musl for Linux builds. This means that there will be some sort of glibc dependency.

This is because fltk-rs is a pain in the proverbial to use with musl, and I can't be bothered to get it 100% working with musl builds.

In the future, when adastral-cli is a thing, then we can switch back to musl builds, since that will not be using any GUI features.

ktwrd commented 4 months ago

Fixed CI not working by removing the feature fltk-bundled when using the crate fltk and using gnu instead of musl (must fix this later, tried for about an hour :/ )

ktwrd commented 3 months ago

code looks good, no issues with documented instructions or dialog functionality.

that's so epic. lgtm?