ku1ik / git-dude

Git commit notifier
http://ku1ik.com/
GNU General Public License v3.0
948 stars 68 forks source link

duplicate notification at every interval #19

Closed glortho closed 13 years ago

glortho commented 13 years ago

I'm currently getting the same "new branch ss/date]" notification every 60 seconds. Whoever created this branch quickly deleted it, but the notification continues. Is this just a parsing issue?

ku1ik commented 13 years ago

"]" at the end of string suggests that it's parsing issue indeed. Can you run git dude with following command?

bash -x <path/to/git-dude> <your-dude-dir>

This will print everything that happens in the script and it would help me analyze the problem. I only need the part where git fetch is issued and following lines up to notify command.

glortho commented 13 years ago

thanks for the quicky reply! here it is:

++ git fetch -v ++ grep -F -- '->'

ku1ik commented 13 years ago

Thx. I will look into it in few hours and hopefully make a fix.

ku1ik commented 13 years ago

I see " git fetch -v". git-dude doesn't use "-v" switch anymore for some time. Can you download latest script version and check if it still gives you this issue?

glortho commented 13 years ago

Just downloaded (first via curl then via brew, and did the x chmod) and now git-dude won't run at all. Double-checked PATH, tried to run with absolute path, checked perms, exited and re-entered shell, all no luck. Any thoughts about that?

EDIT: Running it with your command above yields these four lines and nothing else:

ku1ik commented 13 years ago

Please check your dude.interval setting in ~/.gitconfig. Looks like it's empty.

glortho commented 13 years ago

I set up an interval (there was no dude.interval or [dude] at all in my config – I had been using defaults) and still had problems, but noticed it was failing on the icon setting. I added that in and now everything seems to be running well. No sign of the duplication problem yet. Does this mean git-dude no longer has the default settings? Or maybe something else was screwy in my set-up...

ku1ik commented 13 years ago

Indeed you have found a bug with defaults not working ;) Looking into that.

ku1ik commented 13 years ago

Fixed in master, now the defaults are working again.