ku1ik / rainbow

Ruby gem for colorizing printed text on ANSI terminals
MIT License
813 stars 68 forks source link

minimum version of ruby supported making Github Action rubocop crash + version missing on rubygems #106

Closed noraj closed 3 years ago

noraj commented 3 years ago

On my computer bundle exec rubocop gives no offenses or error (ruby 2.7).

But on the CI (Github Action, image ruby 2.6) I get an error because ruby 2.1 is not supported by rubocop. Rubocop detects ruby 2.1 in TargetRubyVersion of Rainbow rubocop file. It seems to be because I use the paint gems that requires rainbow 3.0.0 which is the last version available on rubygems.

Seems you know requires ruby 2.3 in git tag 3.1.0 but it will still crash since rubocops says:

Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

So could you requires at least ruby 2.4 in the rubocop file (and gemspec for no mismatch or disable the cop that check that), I don't really understand why rubocops on the CI is running on all the sub-dependencies instead of just my code, my best guess is that I requires paint here that itself requires rainbow.

So please:

  1. Release 3.1.0 on rubygems
  2. Make a new 3.2.0 with ruby 2.4 as min version and release it on rubygems
olleolleolle commented 3 years ago

Duplicates #95.

Thanks for reporting!

noraj commented 3 years ago

@olleolleolle Not dupe. #95 is an issue from 2019 when there was only rainbow 3.0.0 that asked to create a new version 3.1.0 with ruby 2.3 as min. In the meantime (august 2020) rainbow 3.1.0 was released (git tag). My issue #106 is asking 2 things:

which is different from creating a 3.1.0 version (which is already done) so you could close #95 and re-open this one.

olleolleolle commented 3 years ago

The problem of access remains the same, though. As soon as that's cleared up, releases can be cut etc.

noraj commented 3 years ago

Please Github CI of thousands of tools are failing because of rainbow 3.0.0 min ruby requirements.

image

noraj commented 3 years ago

I'll try this workaround https://github.com/rubocop/rubocop/issues/6398#issuecomment-431901995 in the meantime