search

ku1ik / rainbow

Ruby gem for colorizing printed text on ANSI terminals
MIT License
813 stars 68 forks source link

Properly add windows-specific deps #29

Closed elifoster closed 8 years ago

elifoster commented 8 years ago

This handles #19 properly, using a Specification extension rather than doing it through bundler.

ku1ik commented 8 years ago

The filenames don't seem to properly match: mkrf vs mkfr.

elifoster commented 8 years ago

@sickill Ping :P

ku1ik commented 8 years ago

@elifoster oh, I didn't notice your last commit. Thanks!

ku1ik commented 8 years ago

@elifoster looks like this broke the build on Rubinius: https://travis-ci.org/sickill/rainbow/jobs/110784324 Can you look at it?

elifoster commented 8 years ago

Super strange. I honestly have no clue why this commit in particular would cause that...

ku1ik commented 8 years ago

If we don't figure out why this fails on Rubinius I'm considering reverting this change.

While one could argue that by supporting Windows we support more users than by supporting Rubinius, it's this unknown behavior that occurs on Rubinius now that is worrying me, because we don't know what's wrong here versus knowing exactly why it didn't work on Windows. Not sure if I made myself clear, but yeah, my current thoughts.