search

ku1ik / rainbow

Ruby gem for colorizing printed text on ANSI terminals
MIT License
813 stars 68 forks source link

mkrf_conf: Improve the check to install win32console #31

Closed sschuberth closed 8 years ago

sschuberth commented 8 years ago

This is only required for Ruby < 2.0. Also recognize Cygwin as Windows.

Closes #19 for good :-)

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 99.129% when pulling 11690f6cae54e9f3912fdf31c443b8ef9c61a3ce on sschuberth:master into 05547f1f4003785da5628d06895218a9fc820c9f on sickill:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 99.129% when pulling d95f655db8338eea5a4f3f2be07585a69711b302 on sschuberth:master into 05547f1f4003785da5628d06895218a9fc820c9f on sickill:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.001%) to 99.128% when pulling cc3996163d6ac5421b0aa4a2d3873f57eb995f0b on sschuberth:master into 05547f1f4003785da5628d06895218a9fc820c9f on sickill:master.

ku1ik commented 8 years ago

Thanks!

ku1ik commented 8 years ago

@sschuberth what do you think about this commit I merged few months ago? https://github.com/sickill/rainbow/commit/d9134a42001ea5517c1d0b14be0ecd57cdc619ac Should this be reverted given your new fix? I'm really not familiar with Ruby on Windows...

sschuberth commented 8 years ago

I believe using ext/mkrf_conf.rb to support platform-specific dependencies is the correct way to go, also see this answer, so no need to revert.

Also, I'm working on a slightly related other fix to make rainbow also work in Cygwin's / MSYS2's mintty terminal on Windows. In that context I'd need to add code to ext/mkrf_conf.rb anyway.

ku1ik commented 8 years ago

Ok, sounds good. Thanks for clarification.