ku1ik / rainbow

Ruby gem for colorizing printed text on ANSI terminals
MIT License
813 stars 68 forks source link

Add open-ended rake dependency #58

Closed mattrayner closed 7 years ago

mattrayner commented 7 years ago

In order to address [#57] I have added an open-ended Rake dependency to this gem. Currently when building in environments such as Ubuntu or Alpine linux with applications such as Sinatra (that do not require rake) any gem including Rainbow will cause bundler to fail.

We may want to look at what version of Rake you really require. But in the meantime, a dependency on Rake should be added to the gemspec ASAP

ku1ik commented 7 years ago

Hey @mattrayner. I'll be releasing rainbow v3.0 very soon, which doesn't have this problem (it doesn't have native ext, doesn't require rake).

We're discussing it here: https://github.com/sickill/rainbow/pull/46#issuecomment-293338766

ku1ik commented 7 years ago

Thanks! Releasing 2.2.2 with this patch right now.

mattrayner commented 7 years ago

Thanks Marcin Kulik :-) On Fri, 21 Apr 2017 at 14:00 Marcin Kulik notifications@github.com wrote:

Thanks! Releasing 2.2.2 with this patch right now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sickill/rainbow/pull/58#issuecomment-296183995, or mute the thread https://github.com/notifications/unsubscribe-auth/ADVzNlVLc6jtmZplMT9SkcfaCcerO-sZks5ryKhagaJpZM4M4sYg .

ioquatix commented 7 years ago

Any update on when rainbow 3.x will be released?

ku1ik commented 7 years ago

@ioquatix Could you use gem "rainbow", github:"sickill/rainbow"` in your Gemfile, and check if all is good? I haven't had time to test this and unfortunately also haven't heard from people whether current master version solves all the rake/installation problems.

mattrayner commented 7 years ago

It fixes it for me 👍🏻 On Wed, 11 Oct 2017 at 08:14 Marcin Kulik notifications@github.com wrote:

@ioquatix https://github.com/ioquatix Could you use gem "rainbow", github:"sickill/rainbow"` in your Gemfile, and check if all is good? I haven't had time to test this and unfortunately also haven't heard from people whether current master version solves all the rake/installation problems.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sickill/rainbow/pull/58#issuecomment-335707432, or mute the thread https://github.com/notifications/unsubscribe-auth/ADVzNgN7rgLh02h05lzklEa-V2XOs43Lks5srGrpgaJpZM4M4sYg .

ioquatix commented 7 years ago

Can you release this as 2.3?

ku1ik commented 6 years ago

@ioquatix we'll just release 3.0, which is pretty much ready. See #72.

ioquatix commented 6 years ago

Any update on this?