ku1ik / rainbow

Ruby gem for colorizing printed text on ANSI terminals
MIT License
813 stars 68 forks source link

Release 3.0 #72

Closed ku1ik closed 6 years ago

ku1ik commented 6 years ago

Branch for last pre-release fixes. As this is major release we can look for some stuff to change. I don't see anything else other than what I updated in these few commits.

Do you have anything to add here @olleolleolle ? I added you as author to gemspec as you're the maintainer. Feel free to revert if you don't like it.

olleolleolle commented 6 years ago

@sickill Thanks for adding my name to the credits list. I'm OK with it. I'm a maintainer, so we're 2 now.

ku1ik commented 6 years ago

Yes, I often mistake the for a ;)

olleolleolle commented 6 years ago

@sickill Now, if we're targetting 2.1+, we have support for Refinements. Then, the Refinements PR could be brushed up and added.

ku1ik commented 6 years ago

Aha, that's good idea!

ku1ik commented 6 years ago

Also realized that having refinements we can drop the legacy String mixin support completely.

olleolleolle commented 6 years ago

@sickill Would it be right to drop in the Refinements thing now (during a major update), and force people to change their usage, or is that a lot to ask of people which depend on this library? (The cost of being popular: can't change. "Avoid success at all costs" --Simon Peyton Jones)

ku1ik commented 6 years ago

Hmm, good point about popularity. It's not harmful to keep the old String mixin. What we could do:

Sounds good?

olleolleolle commented 6 years ago

@sickill That sounds prudent, 👍