search

ku1ik / rainbow

Ruby gem for colorizing printed text on ANSI terminals
MIT License
813 stars 68 forks source link

JRuby support! #74

Closed headius closed 6 years ago

headius commented 6 years ago

Looks like @olleolleolle is way head of me :-)

I just ran into this while trying to run Mastodon on JRuby, because it depends on i18n-tasks which depends on rainbow 2.2.2, which still had an extension.

I have gathered that the extension is going away, and a 3.0 release without it may come soon. What can I do to help? :-)

headius commented 6 years ago

Oh, looks like Mastodon also depends on rainbow directly.

We also ran into this with another application...your library is popular!

olleolleolle commented 6 years ago

@headius We're about to integrate that Refinements-to-String PR, #33 - and then kinda call 3.0 a wrap.

Q: Will using Refinements be a head-ache to JRuby support? No, right?

headius commented 6 years ago

Q: Will using Refinements be a head-ache to JRuby support? No, right?

Yes, potentially!

We have partial refinements support. Simple things work, but we know we have gaps. Also, refinements don't JIT in JRuby right now...so the code containing them will run slower.

FWIW, I still believe refinements are an abomination, but we will support them. Please test this thoroughly on JRuby and I'll fix whatever you find.

olleolleolle commented 6 years ago

@headius Thanks for the update and the notes - it guided the effort on #33.

ku1ik commented 6 years ago

I just pushed 3.0 to rubygems. Should we close it for now and open new JRuby-related issues (if needed at all)?

olleolleolle commented 6 years ago

@sickill I'll close this as finished.