search

ku1ik / rainbow

Ruby gem for colorizing printed text on ANSI terminals
MIT License
813 stars 68 forks source link

Release 3.0.1 (or 3.1)? #95

Closed cllns closed 2 years ago

cllns commented 5 years ago

master has TargetRubyVersion: 2.3. Similar issue to: #87 and #88.

Released gem 3.0.0 only includes PR's through #79.

We could use a released gem that includes the newer PR's. We're running into an issue with Ruby 2.1 being targetted from 3.0.0 (even though we don't need it) See: https://github.com/hanami/cli/pull/54

I'm not sure if it should be 3.0.1 or 3.1.0, since I don't know of all the changes. Might be better to bump to 3.1.0 to be safe?

Thank you!

luke-hill commented 4 years ago

See my updated issue #102 The issue is the gemspec doesn't filter out these files. And as such they've always been getting pulled down.

When they're auto-required in different ways (Such as vendor/bundle), or rubocop styling gems that are custom, you get differing behaviours.

olleolleolle commented 4 years ago

Hi @sickill - sorry to bother you, but I was preparing a release, and ran the code to do that, and then after entering the 2FA code, I saw this:

You do not have permission to push to this gem. Ask an owner to add you with: gem owner rainbow --add olle.jonsson@gmail.com

Do you think you could add me?

luke-hill commented 4 years ago

ping @sickill This is quite a heavily consumed gem (As a direct downstream consumer of rubocop), can we get this release / perms for olle expedited? It's causing a few issues.

luke-hill commented 3 years ago

Any updates on this @sickill / @olleolleolle - Kinda causing us a few issues.

olleolleolle commented 3 years ago

(Could help, if I had access.)

luke-hill commented 3 years ago

Re-ping @sickill Could you look into this. rainbow is actively consumed by rubocop (Hence 143million+ downloads), it would be good to avoid having you as a bus factor (And the only person able to release). Is there any way you can get olle, or someone else able to release?

mvz commented 2 years ago

@olleolleolle If there is no response from @sickill maybe it's time to fork the gem?

olleolleolle commented 2 years ago

@mvz Do you know of an organization that would be willing to host it? Perhaps Rails?

luke-hill commented 2 years ago

Before we do that, do you have publish authority? Because otherwise this is moot.

olleolleolle commented 2 years ago

@luke-hill Thanks for asking, I do not.

ku1ik commented 2 years ago

Hey! Sorry, I couldn't look into this earlier!

@olleolleolle I've now added you as an additional owner of this gem at rubygems (used olle.jonsson@gmail.com email from your example above for the invitation). Let me know if it worked or you prefer to use a different email these days.

As you all noticed I haven't given too much attention to this project in recent years, which I regret, but realistically I probably won't be the best maintainer given I haven't been using Ruby for years now, lost the contact with the ecosystem whatsoever.

As of now @olleolleolle has both access to this repo and the project on rubygems.org so hopefully I won't be the blocker anymore. If anyone else would like to take over then I'm happy to add more collaborators. Also, if you prefer to move this repo under a separate GH org then I'm fine with this, but I'm equally fine to leave it under my account.

olleolleolle commented 2 years ago

@sickill Acknowledged, and I now have access to perform releases. It'd be good to be more hands on this, though, so I'll repeat what Marcin said: happy to add more collaborators.

olleolleolle commented 2 years ago

I would like now to release the Git tag v3.1.0 as a RubyGems release 3.1.0. That's my current plan. I hope it will work.

olleolleolle commented 2 years ago

Now we have a release of https://rubygems.org/gems/rainbow/versions/3.1.0

olleolleolle commented 2 years ago

Closing this, and thanks for being so patient, everyone.