search

kuanb / peartree

peartree: A library for converting transit data into a directed graph for sketch network analysis.
MIT License
201 stars 23 forks source link

[simplify] Reduce dependencies in toolkit #107

Closed kuanb closed 5 years ago

kuanb commented 5 years ago

Toolkit utilizes (part of) OSMnx's simplify graph step. This and the plot method are the only two steps that utilize OSMnx. Due to OSMnx's large array of capabilities, I'm opting to simply copy over the contents of the simplify graph method with minor modification (and full citation/reference to source material) into the peartree repo to attempt to reduce dependencies.

codecov[bot] commented 5 years ago

Codecov Report

Merging #107 into master will decrease coverage by 0.88%. The diff coverage is 82.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage    91.8%   90.92%   -0.89%     
==========================================
  Files          13       13              
  Lines        1001     1058      +57     
==========================================
+ Hits          919      962      +43     
- Misses         82       96      +14
Impacted Files Coverage Δ
peartree/paths.py 95.74% <ø> (ø) :arrow_up:
peartree/graph.py 97.14% <100%> (ø) :arrow_up:
peartree/synthetic.py 98.5% <100%> (+0.03%) :arrow_up:
peartree/plot.py 84.61% <60%> (-15.39%) :arrow_down:
peartree/toolkit.py 92.27% <77.77%> (-4.45%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25a8353...dfdfb4b. Read the comment docs.