Closed kuanb closed 5 years ago
@kuanb there may be a bit more to this change. Partridge is now unzipping files as part of load_feed
, which means that instantiating the Feed
class directly now requires a directory path of the unzipped files. If you're already dealing with directories then only the class name will change. This change cleaned up the Feed
class significantly but restricted the input to directories. Does that make sense?
A quick fix would be to cut a new release pointing to Partridge v0.11.0.
Thanks @invisiblefunnel for the clarification. Was trying to make a quick change while at work - clearly didn't pan out. :)
Will look into this tonight.
Merging #120 into master will decrease coverage by
0.06%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 91.53% 91.46% -0.07%
==========================================
Files 13 13
Lines 1110 1113 +3
==========================================
+ Hits 1016 1018 +2
- Misses 94 95 +1
Impacted Files | Coverage Δ | |
---|---|---|
peartree/graph.py | 97.11% <ø> (ø) |
:arrow_up: |
peartree/summarizer.py | 97.5% <ø> (ø) |
:arrow_up: |
peartree/toolkit.py | 92.3% <ø> (ø) |
:arrow_up: |
peartree/paths.py | 95.31% <100%> (-1.41%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4fc41f7...0402008. Read the comment docs.
Fixes https://github.com/kuanb/peartree/issues/119