search

kuanb / peartree

peartree: A library for converting transit data into a directed graph for sketch network analysis.
MIT License
201 stars 23 forks source link

Lock to v1.0.0 on partridge #141

Closed kuanb closed 5 years ago

kuanb commented 5 years ago

Lock to v1.0.0 on partridge dependency Why? Since 1.1 has breaking changes

Do this until I update how Feed class is handled; then can update to 1.1

invisiblefunnel commented 5 years ago

Hey @kuanb! What are the breaking changes for you in 1.1.0? I'll try to avoid that in the future.

kuanb commented 5 years ago

Hey @invisiblefunnel no worries.

So, spun up a fresh container and ran:

pip install peartree partridge

Then dropped into python:

~$ python
Python 3.7.3 | packaged by conda-forge | (default, Mar 27 2019, 23:01:00)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import partridge as ptg
>>> ptg.__version__
'1.1.0'
>>> import peartree as pt
>>> pt.__version__
'0.6.1'

... annndd it works. I think the issue I was receiving/was reported was on an older version of peartree now that I look at it more. Thanks for pointing that out. This PR was the result of me conflating the memory of how the Feed class had been updated with failing to do due diligence on the bug report. Got too many things going on at the same time... distracted poor/maintenance/support here... :(

At any rate, thanks for pointing that out. I'll revert this.