search

kuanb / peartree

peartree: A library for converting transit data into a directed graph for sketch network analysis.
MIT License
201 stars 23 forks source link

Use the same DataFrame in the filter that is being filtered #166

Closed bryanculbertson closed 3 years ago

bryanculbertson commented 3 years ago

This is an completely untested proposed fix for https://github.com/kuanb/peartree/issues/165

kuanb commented 3 years ago

Ergh I think test error is result of the version of OSMnx I use being way out of date.

kuanb commented 3 years ago

@bryanculbertson if you rebase master you should be able to retrigger test and it should pass - thanks!

codecov[bot] commented 3 years ago

Codecov Report

Merging #166 (15c6f73) into master (ef4a97f) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          13       13           
  Lines        1148     1148           
=======================================
  Hits         1054     1054           
  Misses         94       94
Impacted Files Coverage Δ
peartree/parallel.py 96.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef4a97f...15c6f73. Read the comment docs.

bryanculbertson commented 3 years ago

@kuanb rebased and tests pass!

kuanb commented 3 years ago

Thanks, I'll cut a new release!