kuanyui / BooruShinshi

A WebExtension to download image with comprehensible filename from Booru page in one click.
https://addons.mozilla.org/en-US/firefox/addon/booru-shinshi
Other
13 stars 1 forks source link

Past around 500 tags the Tag Block List will not save #8

Closed Azriel-Satan closed 1 month ago

Azriel-Satan commented 3 months ago

I am an unusual case as I maintain a very long list of artists I have Blocked (currently standing at 1874 artists totaling 2036 tags) and use the Block List function to exclude followed artists when looking for new ones (totaling 2856 tags). In attempting to use to tag blacklist from Booru Sushi to get around sites that do not have functional Block Lists (Rule34) or have aggressive Cloudflare settings (Gelbooru), I discovered that somewhere past the 500 mark, it would not save inputs made to the blocklist.

kuanyui commented 3 months ago

I have never set any length nor amount limit on block list, so don't sure why you encounter this problem...

Can you provide your setting file for debugging? (press "Export as JSON" in BooruShinshi's setting page)

2024年7月18日(木) 13:30 Azriel-Satan @.***>:

  • Changes to the Block List textbox are not saved if more than 500 tags are inputted.
  • This limitation is present when using both newlines and spaces.
  • 500 is not an exact limit, but it functions there and not at 600.

I am an unusual case as I maintain a very long list of artists I have Blocked (currently standing at 1874 artists totaling 2036 tags) and use the Block List function to exclude followed artists when looking for new ones (totaling 2856 tags). In attempting to use to tag blacklist from Booru Sushi to get around sites that do not have functional Block Lists (Rule34, Gelbooru) or have aggressive Cloudflare settings, I discovered that somewhere past the 500 mark, it would not save inputs made to the blocklist.

— Reply to this email directly, view it on GitHub https://github.com/kuanyui/BooruShinshi/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKOPVW6IZV6WPQRCE5LSKTZM5HH5AVCNFSM6AAAAABLB5LTFSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTKMZRGQYTSNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Azriel-Satan commented 2 months ago

BooruShinshiSettings_20240719_040059.json

kuanyui commented 2 months ago

I've tried your setting file, but cannot reproduce the issue you've described.

I entered random tags after your tags, and it still can save without any problem.

  1. Consider backing up your settings JSON file and reinstalling Booru Shinshi?
  2. Are you sure your Firefox is update-to-date? (My platform: Firefox 127)
  3. Have you ever try to create a new clean Firefox profile (startup Firefox via firefox -P), and try to reproduce it with your settings JSON file?

2024年7月19日(金) 16:06 Azriel-Satan @.***>:

BooruShinshiSettings_20240719_040059.json https://github.com/user-attachments/files/16309156/BooruShinshiSettings_20240719_040059.json

— Reply to this email directly, view it on GitHub https://github.com/kuanyui/BooruShinshi/issues/8#issuecomment-2238603369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKOPVWFWI3WS6PMLIOZDULZNDCJDAVCNFSM6AAAAABLB5LTFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZYGYYDGMZWHE . You are receiving this because you commented.Message ID: @.***>

kuanyui commented 1 month ago

No more response, no more information, close as invalid issue.

Azriel-Satan commented 1 month ago

I run Librewolf as my Main. Installed a Fresh instance of Firefox Version 129.0.2 and pasted my block list; despite the Settings Saved popup, it returns to the previous state when the tab is reloaded. Testing it, I was able to save up to 566 tags, but further attempts saw that I was able to save part of the next tag; the most I could get it to store was 5759 characters; past that point, no changes are kept. Removing the filename template allowed additional tags to be added, so its possible there is a hard limit. Removing the Filename template allows additional characters to be added equal to the Filename template's length. BooruShinshiSettings_20240826_225113.json