manifest.json: clarify Wikipedia search page

kuanyui / EngineSwitcher

A WebExtension let you switch search engine in one click.

https://addons.mozilla.org/en-US/firefox/addon/engine-switcher/

5 stars 2 forks source link

manifest.json: clarify Wikipedia search page #17

Open vitaly-zdanevich opened 2 months ago

vitaly-zdanevich commented 2 months ago

Against the problem that now we have the UI on every Wikipedia page:

kuanyui commented 2 months ago

But if do so you cannot jump from homepage of wikipedia (ex: https://en.wikipedia.org/wiki/Main_Page) to other engine, like the other search engines. I mean, this result a different behavior compared to other engine.

This is why I think Wikipedia/YouTube is not very suitable for this WebExtension: Wikipedia / YouTube provide not only search result but also the content of search result.

And sorry, I force push some commits to master due to my typo in commit message, I should open a new branch to merge these PR in local. I will fix these in my side.

vitaly-zdanevich commented 2 months ago

But if do so you cannot jump from homepage of Wikipedia

But the main page is not a Search Engine Result Page (SERP), we do not need to jump from it...

kuanyui commented 2 months ago

But if do so you cannot jump from homepage of Wikipedia

But the main page is not a Search Engine Result Page (SERP), we do not need to jump from it...

But this is exactly current behavior, and I feel this is somewhat convenient...

I also have made another WebExtension of similar feature (with same keyword to switch between different websites' search results page), this increase the complexity of code but necessary to accurately detect the type of page (a search results list / a result item), like this, what I had done in BooruShinshi https://github.com/kuanyui/BooruShinshi/blob/master/src/modules/abstract.ts#L14-L15:

vitaly-zdanevich commented 2 months ago

with same keyword to switch between different websites' search results page

Would be great to have a shortcut for every search engine, without GUI...

kuanyui commented 2 months ago

with same keyword to switch between different websites' search results page

Would be great to have a shortcut for every search engine, without GUI...

Yes, this is also one of the features I have ever considered during designing this WebExtension in the beginning, but it requires quite much works on options_ui and data structures.

I use this WebExtension on mobile, tablet and a laptop with touchscreen. And even with mouse only, current float buttons are more convenient than I've expected, so I didn't implement this at last.