[MERGED] Dark mode add - Githubissues

kuanyui / EngineSwitcher

A WebExtension let you switch search engine in one click.

5 stars 2 forks source link

Closed vitaly-zdanevich closed 2 months ago

vitaly-zdanevich commented 2 months ago

kuanyui commented 2 months ago

Missing a border like light one:
The background of "currently active engine" is too bright, should also be adjusted to fit dark theme. Maybe #666666 I guess.
Remember :hover style

vitaly-zdanevich commented 2 months ago

Current state:

Hover is not changed, because I think it is ok.

kuanyui commented 2 months ago

Border is too dim and nearly invisible. It should be brighter, maybe #777777

vitaly-zdanevich commented 2 months ago

With #333 its absolutely visible

kuanyui commented 2 months ago

Squashed and merged. And also refactored with CSS variables instead of duplicated rules definitions, see: https://github.com/kuanyui/EngineSwitcher/commit/5c6ab432e43b045f81858043f8aadf05857afb87

Thanks for your contribution!