Wrong variable name at kanji_content_detect.js:24?

kuanyui / Furiganaize

A browser extension allowing the injection of phonetic annotations for Japanese text (furigana) on the fly.

https://addons.mozilla.org/en-US/firefox/addon/furiganaize/

MIT License

64 stars 3 forks source link

Wrong variable name at kanji_content_detect.js:24? #4

Closed Fyren closed 2 years ago

Fyren commented 4 years ago

mutationObserver looks like it should be observer here, but I didn't put any effort into it besides looking up the line of code after seeing the error in my browser console:

https://github.com/kuanyui/Furiganaize/blob/0b1035bea184f0538988be01dbfc4894f59e4594/kanji_content_detect.js#L23-L24

kuanyui commented 3 years ago

Fixed

mngyuan commented 3 years ago

@kuanyui, was this fix included in 0.5.1? Line 24 is still causing

TypeError: MutationObserver.observe: One of 'childList', 'attributes', 'characterData' must not be false.

on every page I visit, and I have 0.5.1 according to Firefox's add-ons page.

kuanyui commented 2 years ago

Fixed.