search

kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!
GNU General Public License v3.0
748 stars 59 forks source link

notmuch: Distinguishable color for single-line message summary #104

Closed jackkamm closed 4 years ago

jackkamm commented 4 years ago

When reading e-mails in notmuch with the dark theme, it is hard to visually tell when one message ends and the next message begins: notmuch-moe-unpatched This patch changes the color of the first-line message summary to gray6, so that it is easier to see that a new message has started: notmuch-moe-patched The default color in the light background (gray94) already works well: notmuch-moe-light But for consistency's sake, I've also added a line to moe-light-theme.el explicitly setting the value of notmuch-message-summary-face to its default.

kuanyui commented 4 years ago

Thanks for PR, please see the review.

kuanyui commented 4 years ago

Thanks for your PR!

jackkamm commented 4 years ago

Thank you for accepting, and for maintaining this wonderful theme. IMO, it is the best theme for emacs.

By the way, I want to note that I did change the color of the header line in the dark theme from the initial screenshot. I didn't get a chance to post a screenshot before the PR was merged, but for future reference here's how it looks now: image It's subtler now, but still visible, and I think more in line with the vanilla theming from notmuch.