search

kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!
GNU General Public License v3.0
748 stars 59 forks source link

Moe-theme-switcher breaks theme background color #108

Closed Aaronzinhoo closed 3 years ago

Aaronzinhoo commented 3 years ago

Hi, I have recently run into a problem when using the dev branch. That causes the moe-theme to be loaded twice, (this makes sense since the switcher loads it within its file as well) and causes the moe-theme-dark and light backgrounds to be merged.

This is my configuration for moe-theme. I notice when I remove (require 'moe-theme-switcher) from my config, the dark theme loads properly. The first image is in regards to the overlapping themes displayed. The second image is to show moe-theme-switcher is loading twice.

(use-package moe-theme
  :straight (:type git :host github :repo "kuanyui/moe-theme.el" :branch "dev")
  :config
  (require 'moe-theme-switcher)
  (setq moe-theme-highlight-buffer-id t)
  (powerline-moe-theme))

Screenshot (4)

Screenshot (5)

I really love your work on theme and hope there is a way to solve this!

Aaronzinhoo commented 3 years ago

After inspecting the code, these are actually two separate issues. I am testing some small changes and will make a PR if the tests work out.

Aaronzinhoo commented 3 years ago

Fixed in PR #109