search

kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!
GNU General Public License v3.0
752 stars 60 forks source link

Add ansi colors for Emacs28 #121

Closed heiwiper closed 2 years ago

heiwiper commented 2 years ago

Emacs 28.1 has introduced new faces for ansi colors as mentioned below (See changelogs for reference):

** ANSI color

*** Colors are now defined by faces.
ANSI SGR codes now have corresponding faces to describe their
appearance, e.g. 'ansi-color-bold'.

*** Support for "bright" color codes.
"Bright" ANSI color codes are now displayed when applying ANSI color
filters using the color values defined by the faces
'ansi-color-bright-COLOR'.  In addition, bold text with regular ANSI
colors can be displayed as "bright" if 'ansi-color-bold-is-bright' is
non-nil.

This pull request adds support for the new faces and uses the same colors which were used for ansi-colors previously.

heiwiper commented 2 years ago

I forgot to mention that I love this theme so much (both variants) and everytime I think I will try a new theme I end up going back because I can't find anything better for my taste. Thank you so much for making this theme <3 !

kuanyui commented 2 years ago

Thanks for your information about Emacs 28's ANSI color.

And I personally also feel this theme can satisfy me the most, so never use any other theme since I made this one. (sure, at first, I made moe-theme was just because, there was just no any theme can satisfied me; at least until 2013)