search

kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!
GNU General Public License v3.0
748 stars 59 forks source link

fix: use unspecified instead of nil for background & foreground #124

Closed Aaronzinhoo closed 1 year ago

Aaronzinhoo commented 1 year ago

Was seeing warnings in the Messages buffer referring to nil being specified for faces instead of unspecified. Saw these lines were the culprit so thought I would make a quick PR to address.

kuanyui commented 1 year ago

Thanks for point out this warning, but I never seen this before, do you know when (what version of Emacs) did unspecified variable (?) in font face become available? I'm just worry about the backward compatibility.

Aaronzinhoo commented 1 year ago

Emacs Version: GNU Emacs 29.0.60 OS: macOS Monterey 12.1

I think the keyword has always been around but has not been recommended until recently. Looking at the source code I can see a commit with the unspecified keyword from almost 23 years ago here

nverno commented 1 year ago

this breaks for me [emacs v30] - I see 'Symbol's value as variable is void: unspecified'.

kuanyui commented 1 year ago

@nverno Hmm.... I tested on GNU Emacs 28.2, under GTK GUI and -nw and both of them are workable...

@Aaronzinhoo Do you have any clue?

Aaronzinhoo commented 1 year ago

I'll look into it when I'm home. Continuing the discussion on #126