search

kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!
GNU General Public License v3.0
748 stars 59 forks source link

Quote unspecified #127

Closed dakra closed 1 year ago

dakra commented 1 year ago

Fix #126

In moe-light/dark unspecified was already quoted everywhere but the quotes were missing in the main moe-themes.el file.

kuanyui commented 1 year ago

Ok let us try it and see if any user complain XD

kuanyui commented 1 year ago

In custom-theme-set-faces, all unspecified are not quoted, so I'm very confused and donno if this is a special variable or keyword in the scope of custom-theme-set-faces.

dakra commented 1 year ago

In custom-theme-set-faces, all unspecified are not quoted

From a quick look they are. They're quoted from the outer list. so e.g.

   `(org-agenda-done ((,class (:foreground ,green-2 :background unspecified))))

everything that doesn't have a , prefix is read literal and not interpreted.

Aaronzinhoo commented 1 year ago

That is right, completely slipped my mind... thanks for catching this. @dakra