#+end_src too dark for moe-dark

kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!

GNU General Public License v3.0

752 stars 60 forks source link

#+end_src too dark for moe-dark #54

Closed joonro closed 8 years ago

joonro commented 9 years ago

Hi,

I just updated the moe-theme from melpa. I found one issue, which is that in moe-dark, the foreground color for #+end_src for code blocks in org-mode is very dark:

#+end_src is above #+begin_src python :noweb-ref IGNORE but you barely see it. Could you please fix this? Thank you so much!

tanzoniteblack commented 9 years ago

See comments on https://github.com/kuanyui/moe-theme.el/issues/40 about why the dark color was chosen

kuanyui commented 9 years ago

I'm curious about if anyone feel this face is a obstacle to using Org's block @@

tanzoniteblack commented 9 years ago

I'm completely indifferent to it.

joonro commented 9 years ago

I agree that making it have the same color as the #+begin_src would be an overkill. But currently it is just too dark - When I'm editing, I'm just not sure if there is #end_src or not. It has caused me to make mistakes (I guess it is different depending on the monitor settings as well). I think making it slightly lighter would surface.

kuanyui commented 9 years ago

When syntax for a block is valid, the block should has a highlighted background immediately. So it never be a question for me...

Like this screenshot, all blocks have a lighter background:

And maybe a tiny tip would be helpful for you: in Org-mode, just create a newline, enter <s (or <q, <h, <e ...etc) then press Tab, it will expand to a source block automatically, so you doesn't need to enter markups for blocks manually nor need to place your attention on if a block syntax is completed.

joonro commented 9 years ago

Thanks for the comment.

I tend to lower the brightness of my monitors at night so it might be especially dark in my monitor. While I prefer to have it more visible, I guess it is just difference in preferences.

kuanyui commented 9 years ago

In fact, I set this face totally invisible at first because it's really useless at all when you editing =w="

But you mean the background color looks insignificant in your monitor... Hmmm... #3a3a3a & #303030 in most monitors should be not difficult to distinguish ... Maybe try to adjust the contrast of your monitor?

If you're still unsatisfied... I think it should be well to add a var to config this.

joonro commented 9 years ago

No the background highlighting for source code block is fine.

When I opened this issue I was not aware that it was intentional, and I assumed that the dark #+end_src was a bug. But now I know it was intentional, maybe I will get used to it. At first I was a bit worried about not being able to quickly see #+end_src, but as you said, as long as the background highlighting is correct, I don't have to worry about #+end_src. I do agree that it looks clean.

Thank you so much for your quick replies! I will report back if I face some problems because of this in the future.

breadncup commented 6 years ago

Would you add a var to config of this, please? It's too dark for me as well. I need to see where the "END" is located as well.

kuanyui commented 6 years ago

Practically, you needn't to see that string anyway. Just see where's the bottom of the gray background.

breadncup commented 6 years ago

Yeah, but if you give an option to a user to config it, it would be great as well. Or, like #+BEGIN_SRC, if there is a bar in the "END", it would be easier to look for me. It's personal preference, though.