search

kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!
GNU General Public License v3.0
752 stars 60 forks source link

Hardcoded foreground color #61

Open YorkZ opened 9 years ago

YorkZ commented 9 years ago

Hi Kuanyui,

I like your theme, thank you very much!

However, as I was trying to change the default foreground color to black-6, I noticed that the foreground color has been hard coded in the function moe-light. I've seen you explanation a few lines before, however, I'm not sure whether that affects only the background color. If so, do you think we should remove the line that hard coded the foreground color?

Thank you

kuanyui commented 9 years ago

I don't sure what you're talking about. Can you take a screenshot for it?

YorkZ commented 9 years ago

Below is the code in the function moe-light, file moe-theme.el, line 282 to 287:

;; In Emacs 24.3.50.1 , background-color may cannot be changed under GUI Emacs.
;; So do this again.
(if window-system
    (progn
      (set-background-color "#fdfde7")
      (set-foreground-color "#5f5f5f")))

Because line 287 hard coded the foregroud color to #5f5f5f, it's impossible for users to customize this color. Of course user could still "customize" this color by calling set-foreground-color again, but that's ugly!

York

kuanyui commented 9 years ago

Sorry...I still cannot get what you exactly want to ask/do. @_@ If you really want to change that face by yourself, just fork repo and change it, or add set-foreground-color in your config file. And the background color in GUI & console is slightly difference due to the limitation of 256-color, so the lines is necessary I think.