kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!
GNU General Public License v3.0
748 stars 59 forks source link

buffer name square around #82

Closed mashu closed 6 years ago

mashu commented 7 years ago

Hi,

Attached screen shows that buffer name "emacs-init.org" has not consistent orange color when not in focus. The square around it looks ugly.

My config you can also see in the attached screenshot or here emacs

Thanks for help!

kuanyui commented 7 years ago

I guess (setq moe-theme-mode-line-color 'orange) and (moe-dark) are the reason.

Try to remove the two lines, just use (load-theme 'moe-dark).

mashu commented 7 years ago

I try this

emacs2

As suggested I removed those lines and use only what you state on your website. Theme looks good when in focus (except of white strip which I dont like) but when buffer is not active see attached picture rectangle around buffer name.

kuanyui commented 7 years ago

If you want to use (powerline-moe-theme), use (moe-dark). If you don't want to use (powerline-mode-them), use (load-them 'moe-dark)

I also feel this is so annoying...

mashu commented 7 years ago

Thanks, however my problem is still present. (first inactive, second active buffer) diffemacs

Here is config

(use-package powerline
  :ensure t
  ;;:init (powerline-default-theme)
  :config
  ;; (setq powerline-default-separator 'wave)
  (use-package moe-theme
    :ensure t
    :config
    ;;(setq moe-theme-mode-line-color 'orange)
    (moe-dark)
    ;;(load-theme 'moe-dark)
    (powerline-moe-theme)
    ;; Highlight block with matching parens
    (show-paren-mode t)
    (setq show-paren-style 'expression)
    )
  )
kuanyui commented 7 years ago

Sorry, I cannot reproduce your issue on my system. (Both console & GUI Emacs. Emacs 25.1, latest moe-theme & powerline) with only two lines of settings:

(moe-dark)
(powerline-moe-theme)

md8

BTW, There are a lot of implements of powerline, are you sure the powerline you're using is this one? md8

mashu commented 7 years ago

Hi, Looks like i have exactly the same version. emacs2

Steps to reproduce.

  1. Start emacs
  2. C-x 2 to split window in two
  3. Click other application window (i.e browser but not emacs window) to lose focus on Emacs
  4. Use Alt+Tab to select Emacs window again
  5. Active buffer is not blue entirely, just the buffer name

When I click inside Emacs on each buffer, it selects blue correctly and inactive is also correct. But when I lose focus on Emacs window and come back with Alt+Tab, previously active buffer is not highlighted correctly.

I made a short 57 sec screencast of the problem seen at the end of movie https://vimeo.com/189513267

kuanyui commented 7 years ago

Ugh! If the issue involve the WM/DE on your system...It seems beyond the range which I can handle.

Your screencast looks indeed very bizarre, it looks you're using GNOME3 + GUI version Emacs. I just tested on KDE5 & OS X + GUI Emacs, but both cannot reproduce the phenomenon you encountered.

I'm not sure this issue is due to Emacs itself or moe-theme... Because I still cannot reproduce what you've encountered, maybe you can try to take a look of the code of the related part and modifying by yourself until it solve the problem, L475~482 handle powerline faces. If really solved, feel free to share your patch. ;)

(BTW, your issue only occurs when Emacs losing its focus, I don't think that's a unacceptable problem. :sweat: . But about Helm... I also encountered. It may be unsolveable, or more precisely --- I have no patience and free time to see what Helm have done on mode-line for such a subtle flaw.)

md8

choma commented 7 years ago

I can confirm the issue. I'm using emacs 24. M-x emacs-version shows :

GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.21.5) of 2016-09-05 on trouble, modified by Debian

I'm on gnome 3 (version 3.22.1).

mashu commented 7 years ago

@kuanyui in your screenshot you have the same problem as me and @choma The scratch has grey right triangle which should be forest green color.

I disabled loading of helm completely, and problem persists, so it's not Helm fault I think. Then I disabled loading of every package except for powerline and moe-theme, same problem.

@choma I am also using Debian, would it be possible to try on Ubuntu by someone ?

kuanyui commented 7 years ago

This issue should not be related to distro, window manager instead, I guess.

@kuanyui in your screenshot you have the same problem as me and @choma The scratch has grey right triangle which should be forest green color.

You were misunderstood. At lease on KDE5 & OSX 10.11, I don't have any problem you've encountered, except for Helm.

I disabled loading of helm completely, and problem persists, so it's not Helm fault I think. Then I disabled loading of every package except for powerline and moe-theme, same problem.

Sorry, I don't have any idea.

Take a look: md8

choma commented 7 years ago

I guess this is not a moe-theme issue, but a powerline one, see:

I think this should be closed.

angelovalderrama commented 7 years ago

Same issue, it's a powerline problem, close this issue...