search

kuanyui / moe-theme.el

A customizable colorful eye-candy theme for Emacser. Moe, moe, kyun!
GNU General Public License v3.0
752 stars 60 forks source link

Request to adjust ivy and swiper match face foreground colours. #99

Open bhrgunatha opened 5 years ago

bhrgunatha commented 5 years ago

I understand you take the aesthetics of moe very seriously and it's my favourite emacs theme both the dark and the light but I can't live without the dark version!. It's the only theme I've used for several years now.

However using it with swiper and ivy is very difficult to read - the text foreground colour of the matches are far too light to read (in particular the light green and light blue background colours with multiple matches) - they both cause me eye strain. I have to change them in my config but I would like it if you could change them in moe to something with more contrast to make it more readable.

Dark theme example: Light theme example:

I can easily fork it and change it myself but then I would have to patch it every time it's updated. I know it's not often but it would be better for an upstream fix :)

kuanyui commented 5 years ago

Hi @bhrgunatha : Thanks for your using. Are the two screenshots your forked version?

bhrgunatha commented 5 years ago

No they were taken with version 20180617.200 from melpa

I've changed the colours in my forked version - commit 7d8618aa to make it more readable but I'm no designer :( and I'm certain you can make better choices than me.

kuanyui commented 5 years ago

Some suggestions: (top is fg, down is bg) totally by imagination, maybe still need to be modified. a mmm

I guess the color order from first matched to last can be: green -> blue -> orange -> magenta

kuanyui commented 5 years ago

May I take a look of the screenshot of your current version next time?

bhrgunatha commented 5 years ago

Of course.

This is an example search of moe-dark-theme.el showing the colour changes I made to it

And here is the same for moe-light-theme.el

moe-light is still not very good contrast though . I suck at colours. I will try your suggestions tomorrow (more free time then). Thanks.

bhrgunatha commented 5 years ago

Here are the result of your suggestions and some changes I made which are much better now:

Dark

Light

What do you think?

I re-forked your repo and added those changes which you can see at commit 6f514e32

kuanyui commented 5 years ago

About light version: The background of ivy-current-match should not be same with ivy-minibuffer-match-face-1, maybe setting the latter to yellow-00 would be better.