search

kuba-- / zip

A portable, simple zip library written in C
MIT License
1.42k stars 276 forks source link

Try to fix #123 #344

Closed kuba-- closed 7 months ago

kuba-- commented 7 months ago

Fixes https://github.com/kuba--/zip/issues/342

ouuan commented 7 months ago

The old PoC still works on my machine 🤔

kuba-- commented 7 months ago

The old PoC still works on my machine 🤔

I've refined zip_name_normalize function, so hopefully it's fixed as expected.

ouuan commented 7 months ago

According to the tests, I also believe that it's fixed now.

ouuan commented 7 months ago

BTW, just a small reminder, you can use fixes #342 instead of fixes https://github.com/kuba--/zip/issues/342 to link to the issue and automatically close it on PR merge. ref: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue