search

kuba-moo / mt7601u

Linux mac80211-based driver for Mediatek MT7601U USB bgn WiFi dongle
284 stars 111 forks source link

Allow user to specify MAC address on module load through "mt_initmac" parameter. #74

Closed ghost closed 3 years ago

ghost commented 6 years ago

I'm kind of surprised that I'm the first one to request such a feature.

kuba-moo commented 6 years ago

Hm. Why do we need module parameter? Module parameters are discouraged in networking code by the maintainer, David Miller. Would this upstream commit (from Linus's tree) work for you?

commit 032a552e8dc9d2147e34157bb3b0b23e8f418e43
Author: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date:   Thu Feb 8 23:08:09 2018 +0100

    mt7601u: set device mac address in mt7601u_add_interface()

    If mac80211 adds a vif with a different mac address respect to
    the eeprom one, the device will not be able to connect to the ap
    since the hw address has not been updated.
    Fix the issue updating hw mac address in mt7601u_add_interface routine

    BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1516935
    Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
ghost commented 6 years ago

Basically, I found this to be the simplest possible way to change MAC and still be able to connect to the AP without triggering the above-mentioned bug.

The feature still can be made "togglable" in makefile - for those who really need it for some reason.

Anyway, I will try the version from the upstream and report back in a few days.

ghost commented 6 years ago

And by the way, why didn't you included this commit in your tree? That one looks like a more user-friendly and safe solution than mine. What's the catch?