Open zanderwar opened 1 year ago
Hi @zanderwar,
it seems like a good improvement, would you like to raise the PR? Do we need and option for keep_class_property_docblocks
or should it always work as it is true
?
Currently you only put 1 whitespace in front of the promoted property which doesn't follow standards I believe.
I don't understand, how is it breaking standards? It keeps the padding for what was before.
I think the problem is that the current fixer works like this:
I'd like to either remove the docblock or convert it to @param
ones.
I currently see no case on why we should keep the doc comment
If the existing class property has a doc block, then the positioning of it when it gets moved to the __constructor is a little whack
Adding the following to the bottom of
updateParameterSignature
resulted in perfect positioningA few additional options would be nice:
keep_class_property_docblocks
defaults totrue
padding
defaults to 4spacesCurrently you only put 1 whitespace in front of the promoted property which doesn't follow standards I believe.