search

kube-aws / kube-spot-termination-notice-handler

A Kubernetes DaemonSet to gracefully delete pods 2 minutes before an EC2 Spot Instance gets terminated
Apache License 2.0
378 stars 77 forks source link

[feature] detach from ASG #15

Closed egeland closed 5 years ago

egeland commented 5 years ago

The idea for this came from @Sudiksha and was based on their initial PR.

egeland commented 5 years ago

Just need an approval so I can merge this. I'll build some new images after that!

egeland commented 5 years ago

Thanks for the approval, @Sudiksha - I'll need another from someone with write access, like @mumoshu or @kylegato

egeland commented 5 years ago

@mumoshu , would you mind approving?

Also, could you give @matthope access, so he can help us out?

mumoshu commented 5 years ago

Thanks for your efforts! LGTM.

@egeland Sure. Just invied @matthope to as a collaborator of this repository 😄

Sudiksha commented 5 years ago

@egeland @mumoshu I see you have pushed a new image kubeaws/kube-spot-termination-notice-handler:latest with these changes. Thank you. Can you please push these changes as a tag version rather than latest? Its better from reference perspective.

Sudiksha commented 5 years ago

@egeland Can you please help in adding the new image with a verion tag?

egeland commented 5 years ago

I will, sorry for the delay!

On Thu., 13 Dec. 2018, 05:20 Sudiksha Thukral, notifications@github.com wrote:

@egeland https://github.com/egeland Can you please help in adding the new image with a verion tag?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kube-aws/kube-spot-termination-notice-handler/pull/15#issuecomment-446690056, or mute the thread https://github.com/notifications/unsubscribe-auth/ABONY1JHAkH-ARjIrw1mWgtSUiQtp4LMks5u4UjwgaJpZM4ZF0p2 .