kube-aws / kube-spot-termination-notice-handler

A Kubernetes DaemonSet to gracefully delete pods 2 minutes before an EC2 Spot Instance gets terminated
Apache License 2.0
378 stars 77 forks source link

Why is the asg detach only for regular ASG's? #29

Open bzuelke opened 5 years ago

bzuelke commented 5 years ago

I'm running spot fleets currently and testing out the commands that will detach the ASG seems to work. I'm curious if there was something behind the scenes that I was unaware of that would cause problems?

so0k commented 4 years ago

Are you using spot fleets or mixedInstancePolicies on an ASG?

bzuelke commented 4 years ago

@so0k I'm using spot fleets with mixed instance policies on the ASG. I tested this in our sandbox environment and didn't seem to be an issue but I wasn't really paying uber close attention to it either. I just wasn't sure if there was something observed initially which was reason for the warning about it not being a thing for non basic ASG's. I'll get some testing in and report back in the meantime just to see the behavior.