search

kube-aws / kube-spot-termination-notice-handler

A Kubernetes DaemonSet to gracefully delete pods 2 minutes before an EC2 Spot Instance gets terminated
Apache License 2.0
378 stars 77 forks source link

Support wechat notification #38

Closed DasyDong closed 4 years ago

DasyDong commented 4 years ago

In china we use wechat at most, so I add wechat notification

DasyDong commented 4 years ago

Hello @egeland and @mumoshu, is it possible to review and merge this pr?

DasyDong commented 4 years ago

@matthope Updated, thanks a lot

DasyDong commented 4 years ago

@matthope

@matthope Updated, thanks a lot Hi matthope ,did i miss something？is the pr ready to merge ?

DasyDong commented 4 years ago

/assign egeland

matthope commented 4 years ago

Heya @DasyDong - Please be aware of the points raised in https://github.com/kube-aws/kube-spot-termination-notice-handler/issues/36

DasyDong commented 4 years ago

Heya @DasyDong - Please be aware of the points raised in #36

got it ! I am also contributed in AWS node termination handler , seems that notification about more ways may not be merged in the short time , maybe in future