search

kube-aws / kube-spot-termination-notice-handler

A Kubernetes DaemonSet to gracefully delete pods 2 minutes before an EC2 Spot Instance gets terminated
Apache License 2.0
378 stars 77 forks source link

Upgrade kubectl to 1.15.10 #41

Open igordrnobrega opened 4 years ago

igordrnobrega commented 4 years ago

Upgrade to kubectl v1.15.10

max-rocket-internet commented 4 years ago

I think it's safer to just go to the latest version, no?

igordrnobrega commented 4 years ago

IMO we should do it for especific versions, so we should have this version together with the latest one so you can match with the eks version used. WDYT?

max-rocket-internet commented 4 years ago

I don't think that's required as kubectl is backwards compatible.

igordrnobrega commented 4 years ago

I had an issue few weeks ago with kubectl versions. I was running my instances on AWS with 1.15.10 and using kubectl 1.17.0 while draining some nodes I should see an error about daemonsets and volume data in the output of kubectl drain <node> and with different versions, I didn't get this warning and ended up killing my instances and getting a downtime on my prod environment due to this incompatibility.

savar commented 4 years ago

I also am not convinced that the backward compatibility is granted. Also https://kubernetes.io/docs/setup/release/version-skew-policy/#kubectl states clearly that this is only promised anyways for the current, next and one older version

rendhalver commented 3 years ago

Do we need newer versions as well? The latest release is 1.19 and 1.20 is just around the corner.