search

kube-burner / kube-burner-ocp

OpenShift integrations and workloads for kube-burner
https://kube-burner.github.io/kube-burner-ocp/
Apache License 2.0
4 stars 14 forks source link

[BUG] Waiting for actions to complete message is misleading #45

Closed dry923 closed 2 weeks ago

dry923 commented 3 months ago

Bug Description

When running a workload and reaching the part where it waits for actions to complete the message that is displayed is misleading/ambiguous to the user.

Output of kube-burner-ocp version

$ /tmp/kube-burner-ocp version Version: 1.2.0 Git Commit: 4b931f45d8b04d82d8e2a4902eafdcd5ceafdd85 Build Date: 2024-03-06T17:02:16Z Go Version: go1.19.13 OS/Arch: linux amd64

Describe the bug

The output from kube-burner when it reaches this step shows something like this depending on the Timeout value (in this case 4 hours) 'msg="Waiting up to 4h0m0s for actions to be completed"' However at this point it may have already been 3 hours of running the workload and thus will actually time out in 1 hour. To the user this is a very unclear message and should be rephrased to reduce ambiguity.

To Reproduce

Steps to reproduce the behavior:

  1. Run a kube-burnerr workload such as cluster-density-v2 with a default timeout. Note the start time.
  2. When it reaches the waiting for actions to complete section it will state that it will wait for up to 4 hours.
  3. The real time it will wait will be 4 hours - (current time - start time)

Expected behavior

It states how much longer it will wait precisely OR makes it clear that it will only be waiting for the remainder of the timeout.

Screenshots or output

' time="2024-04-03 12:48:17" level=info msg="🔥 Starting kube-burner (1.2.0@4b931f45d8b04d82d8e2a4902eafdcd5ceafdd85) with UUID 72670a7f-eae9-4a56-9a88-8cc62fa25011" file="job.go:97" ...workload runs... time="2024-04-03 15:08:01" level=info msg="4500/4509 iterations completed" file="create.go:132" time="2024-04-03 15:08:18" level=info msg="Waiting up to 4h0m0s for actions to be completed" file="create.go:181" -- Note that it only actually waited an 1h40m since it had taken 2h20m up to this point. 4 hours from start time time="2024-04-03 16:48:17" level=error msg="4h0m0s timeout reached" file="job.go:272" time="2024-04-03 16:48:17" level=error msg="4h0m0s timeout reached" file="helpers.go:183"'

Additional context

github-actions[bot] commented 3 weeks ago

This issue has become stale and will be closed automatically within 7 days.