kube-burner / kube-burner-ocp

OpenShift integrations and workloads for kube-burner
https://kube-burner.github.io/kube-burner-ocp/
Apache License 2.0
4 stars 18 forks source link

[RFE] Gather container memory working set size #72

Closed mtodor closed 1 month ago

mtodor commented 4 months ago

Is your feature request related to a problem? Please describe.

kube-burner uses container_memory_rss (RSS) to collect metrics about memory usage.

I would suggest starting collecting container_memory_working_set_bytes (WSS). Many applications have stable and low RSS footprints, but the WSS is way bigger. Some examples are Postgres and Prometheus.

In most cases, when WSS reaches container resource limits, it will get OOMKilled. That's why I think that tracking the increase in WSS is more important than RSS.

Describe the solution you'd like

Add additional metrics to gather container_memory_working_set_bytes.

Describe alternatives you've considered

Replaces existing container_memory_rss with container_memory_working_set_bytes, but that will cause previously gathered results to be not comparable with the new ones.

Additional context

Article about cgroups and OOMKilled decisions. A lot of details, but it points out what Kubernetes compares and when OOMKilled will happen.

github-actions[bot] commented 1 month ago

This issue has become stale and will be closed automatically within 7 days.