search

kube-burner / kube-burner-ocp

OpenShift integrations and workloads for kube-burner
https://kube-burner.github.io/kube-burner-ocp/
Apache License 2.0
4 stars 18 forks source link

added image-registry check #82

Closed shashank-boyapally closed 2 months ago

shashank-boyapally commented 3 months ago

Type of change

Description

Added image registry check for kube-burner-ocp, this can be used for bare-metal instances where image-registry co is not present by default.

Related Tickets & Documents

Checklist before requesting a review

rsevilla87 commented 3 months ago

Isn't the registry image registry status already verified by the cluster operators check?

https://github.com/kube-burner/kube-burner-ocp/blob/4a36d42712bd22e9308035149a3de93b33896f54/cluster_health.go#L67-L75

🤔

rsevilla87 commented 3 months ago

I think this PR won't be necessary, if I understood correctly, @venkataanil wasn't passing the --check-health flag to the kube-burner-ocp command, with it the registry readiness should be checked upfront.

rsevilla87 commented 3 months ago

@shashank-boyapally , maybe we should enable this flag by default?, wdyt @jtaleric @afcollins @venkataanil ?

shashank-boyapally commented 3 months ago

I was thinking since we get the list of installed operators, we cannot check the condition of image-registry if it is not present, hence I added an additional check, if I'm not mistaken image-registry is not present when we spin up a bm instance, please correct me if I'm wrong. Yes, we can enable the flag to default true.

shashank-boyapally commented 3 months ago

Looks like the image-registry is present, hence we might not need explicit check to image-registry. Please confirm if I can close this PR as not needed anymore.

venkataanil commented 3 months ago

Its better we get a BM deployment and reporduce this issue and then find root cause and fix it. We can retain this PR till then.

afcollins commented 3 months ago

find root cause

@venkataanil We know it already. Bare metal deployments do not include the image-registry by default.

It is documented as a Day 2 operation.

Configuring a registry is not something kube-burner would do.

rsevilla87 commented 2 months ago

Something is wrong with latest rebase... 9 commits?