Enable health check by default

kube-burner / kube-burner-ocp

OpenShift integrations and workloads for kube-burner

https://kube-burner.github.io/kube-burner-ocp/

Apache License 2.0

4 stars 14 forks source link

Enable health check by default #83

Closed rsevilla87 closed 2 weeks ago

rsevilla87 commented 3 weeks ago

Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[x] Optimization
[ ] Documentation Update

Description

Enabling health check by default

Related Tickets & Documents

Related Issue #79
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

shashank-boyapally commented 3 weeks ago

/lgtm

paigerube14 commented 3 weeks ago

I feel like this could impact a lot of tests, if we add this in here, will we be able to test in e2e-benchmarking/prow before fully merging that we can feel more confident in tests consistently passing before going fully in with it?

rsevilla87 commented 3 weeks ago

I feel like this could impact a lot of tests, if we add this in here, will we be able to test in e2e-benchmarking/prow before fully merging that we can feel more confident in tests consistently passing before going fully in with it?

yeah, the process of adding new features is quite safe and requires several steps:

Merge commit
Cut new release of kube-burner-ocp
Update kube-burner-ocp version in e2e-benchmarking
Run CI tests
Merge PR in e2e-benchmarking
Cut new release in e2e-benchmarking

rsevilla87 commented 3 weeks ago

cc @kube-burner/ocp-perfscale @kube-burner/ocp-perfscale-telco , take a look please, this update is important

josecastillolema commented 3 weeks ago

/lgtm

vishnuchalla commented 2 weeks ago

I feel like this could impact a lot of tests, if we add this in here, will we be able to test in e2e-benchmarking/prow before fully merging that we can feel more confident in tests consistently passing before going fully in with it?

yeah, the process of adding new features is quite safe and requires several steps:

Merge commit

Cut new release of kube-burner-ocp

Update kube-burner-ocp version in e2e-benchmarking

Run CI tests

Merge PR in e2e-benchmarking

Cut new release in e2e-benchmarking

@rsevilla87 for this change, we might also want to run some rehearsals agaisnt a couple of periodic jobs in prow. Maybe against a baremetal and a non-baremetal ones.

rsevilla87 commented 2 weeks ago

I feel like this could impact a lot of tests, if we add this in here, will we be able to test in e2e-benchmarking/prow before fully merging that we can feel more confident in tests consistently passing before going fully in with it?

yeah, the process of adding new features is quite safe and requires several steps:

Merge commit

Cut new release of kube-burner-ocp

Update kube-burner-ocp version in e2e-benchmarking

Run CI tests

Merge PR in e2e-benchmarking

Cut new release in e2e-benchmarking

@rsevilla87 for this change, we might also want to run some rehearsals agaisnt a couple of periodic jobs in prow. Maybe against a baremetal and a non-baremetal ones.

correct, the more checks we can do before running it periodically the better

rsevilla87 commented 2 weeks ago

@afcollins @jtaleric @dry923 @mohit-sheth @josecastillolema

afcollins commented 2 weeks ago

LGTM +1 on the procedure in above comment so we understand any impacts