Allow specifying an existing Floating IP

kube-hetzner / terraform-hcloud-kube-hetzner

Optimized and Maintenance-free Kubernetes on Hetzner Cloud in one command!

MIT License

2.21k stars 345 forks source link

Allow specifying an existing Floating IP #1367

Closed amplitudesxd closed 3 months ago

amplitudesxd commented 3 months ago

Description

We want to use an egress node in our Kubernetes cluster, but occasionally need to drain the node pool, which results in the loss of the Floating IP.

We use this IP in the firewalls and whitelists of external services that our cluster connects to.

Request

Please allow the specification of an existing Floating IP ID for a node. This would help us avoid losing the IP during maintenance, and reduce the operational overhead when this occurs.

WebSpider commented 3 months ago

I never actually looked at the egress gateway, but it's documentation says there's more advanced methods of selecting an exit, rather than "just" the IP address.

Looking at the way this terraform module is set up, it would make sense to either:

Select an existing floating ip, either by IP, label or ID
Create our own floating IP if absent, if desired to do so (selectable by variable)

mysticaltech commented 3 months ago

@amplitudesxd It sounds like a good idea that could be useful for quite a few people, we will look into it, but in the meantime PRs are most welcome.

amplitudesxd commented 3 months ago

I'm afraid I don't think I'm quite experienced enough with Terraform to make a PR, though thank you for taking a look!