kube-hetzner / terraform-hcloud-kube-hetzner

Optimized and Maintenance-free Kubernetes on Hetzner Cloud in one command!
MIT License
2.4k stars 371 forks source link

[Feature Request]: Ability to specify "kube-apiserver-arg" or potential other arguments in YAML format #1513

Closed maaft closed 2 weeks ago

maaft commented 2 weeks ago

Description

currently the only option to set custom options is via control_planes_custom_config option.

control_planes_custom_config = {
   "key"="value"
}

This expects "string"->"string" mappings.

But for configuration options like kube-apiserver-arg, we need to support nested YAML. Example:

"kube-apiserver-arg":
  - "oidc-issuer-url=https://sts.windows.net/4ee01e4d-71a8-4b9e-a038-e7c2e314b532/"
  - "oidc-client-id=59237398-07f6-4b9f-925b-8cb0428c4f14"
  - "oidc-groups-claim=groups"
  - "oidc-groups-prefix=oidc:"
  - "oidc-username-claim=upn"
  - "oidc-username-prefix=oidc:"
maaft commented 2 weeks ago

never mind, its already possible by using a list:

control_planes_custom_config = {
    "kube-apiserver-arg" = [
      "oidc-issuer-url=https://sts.windows.net/4ee01e4d-71a8-4b9e-a038-e7c2e314b532/",
      "oidc-client-id=59237398-07f6-4b9f-925b-8cb0428c4f14",
      "oidc-groups-claim=groups",
      "oidc-groups-prefix=oidc:",
      "oidc-username-claim=upn",
      "oidc-username-prefix=oidc:"
    ]
}