kube-hetzner / terraform-hcloud-kube-hetzner

Optimized and Maintenance-free Kubernetes on Hetzner Cloud in one command!
MIT License
2.4k stars 371 forks source link

Allow cluster with empty agent pool #1546

Open janfrederik opened 6 days ago

janfrederik commented 6 days ago

I only want autoscaler nodes, no fixed agent pools.

Currently, the count logic in the validation for agent_nodepools errors if agent_nodepools is empty (which is the default). The validation doesn't fail, it gives an error. The logic for calculating local.agent_count errors the same way.

However, there is not reason why empty agent pools wouldn't work. I used this patch a while in different combinations (single and multiple control planes, with our without autoscaler_nodepools) and everything looks great.

RRosalia commented 2 days ago

Also voting for this one!