search

kube-logging / logging-operator

Logging operator for Kubernetes
https://kube-logging.dev
Apache License 2.0
1.53k stars 326 forks source link

fix: Add Buffer to Gelf Outputs #1720

Closed bmichalkiewicz closed 4 months ago

bmichalkiewicz commented 4 months ago

This PullRequest adds a buffer section to Gelf Outputs and ClusterOutputs. This might be a bug/mistake as deployed config has a buffer section with flush_mode.

bmichalkiewicz commented 4 months ago

Hey @pepov, I tested it on my development environment and encountered some errors: config error file="/fluentd/etc/fluent.conf" error_class=Fluent::ConfigError error="this plugin 'Fluent::GELFOutput' cannot handle arguments for <buffer ...> section

Since the project https://github.com/hotschedules/fluent-plugin-gelf-hs is no longer maintained, I forked it and made a few changes to get it working properly. The buffer is functioning correctly, and the logs are fine.

pepov commented 4 months ago

Can you perhaps release a gem from it?

bmichalkiewicz commented 4 months ago

https://github.com/bmichalkiewicz/fluent-plugin-gelf-best

you could find it in the releases

bmichalkiewicz commented 4 months ago

Hey, gelf without buffor is useless, we need it so any ideas what do I need to do to replace no longer maintanced plugin with my forked ? We are extensively testing it and works like a charm

pepov commented 4 months ago

We need to pull it into these dockerfiles to replace the originals I just didn't have the time to do this already: https://github.com/kube-logging/fluentd-images

bmichalkiewicz commented 4 months ago

oh fine, take your time 👍

pepov commented 4 months ago

@bmichalkiewicz this will be available once https://github.com/kube-logging/fluentd-images/actions/runs/8878985879 has been built, with build number 139, I think we should add that image ref as a comment: ghcr.io/kube-logging/fluentd:v1.16-full-build.139

bmichalkiewicz commented 4 months ago

@pepov sure, commited :)

pepov commented 4 months ago

@bmichalkiewicz sorry my suggestion broke make check-diff. Please rerun, commit and push and we are ready to accept this. FYI the next release is planned to be available May 21st but we can create a dev tag any time that triggers an image and chart pre-release as well.

bmichalkiewicz commented 4 months ago

I have fluentd:v1.16-full-build.140 already on dev and works as expected oh yeah, let's wait a second and will run it

bmichalkiewicz commented 4 months ago

@pepov make check-diff works now

bmichalkiewicz commented 4 months ago

@pepov fixed ci test