search

kube-logging / logging-operator

Logging operator for Kubernetes
https://kube-logging.dev
Apache License 2.0
1.52k stars 326 forks source link

feat(charts,logging-operator): add possibility to deploy extra manife… #1768

Closed sebastiangaiser closed 3 weeks ago

sebastiangaiser commented 3 weeks ago

…sts to Helm chart

sebastiangaiser commented 3 weeks ago

@pepov maybe you can include that in the upcomming release tomorrow :D Sorry for pushing that but I saw changes on the planned features for the next release.

pepov commented 3 weeks ago

@sebastiangaiser what is the usecase for this? what is the reason against creating an umbrella chart and putting extra resources there?

sebastiangaiser commented 3 weeks ago

My use case are the PrometheusRules from here. But I think this could also make sense in case you want to have some ConfigMap mounted via volume into FluentD, too. I didn't get what you meant with the umbrella chart

pepov commented 3 weeks ago

I meant that you can create a high level chart, add you prometheus resources and add the logging operator as a dependency into that. I haven't really seen this extra resources as a practice this is why I ask.

The term comes from here: https://helm.sh/docs/howto/charts_tips_and_tricks/#complex-charts-with-many-dependencies

pepov commented 3 weeks ago

I've found a few usage for this in the most popular charts, ok for me