kube-logging / logging-operator

Logging operator for Kubernetes
https://kube-logging.dev
Apache License 2.0
1.56k stars 331 forks source link

Reload config involves a loss of logs #791

Open sebastiendejou opened 3 years ago

sebastiendejou commented 3 years ago

Is your feature request related to a problem? Please describe.

When an update of the fluentd's configuration happens from another namespace, the fluentd worker process is restarted. (this way : http://127.0.0.1:24444/api/config.reload) and the problem happens : Logs are lost during reload for the first namespace. Does logging-operator respect the multitenancy agreement ?

Describe alternatives you've considered No one.

Describe alternatives you've considered In a previous issue, "/api/config.gracefulReload" (https://github.com/banzaicloud/logging-operator/pull/454) has been suggested. This issue has been merged, but reverted after that. Is there a mechanism that could gracefully reload the fluentd ?

Regards

pepov commented 3 years ago

It was reverted because it did not handle plugin params as expected. Things might have changed with latest fluentd versions though. I would consider making this configurable and let users experiment with it until we can get back to this and retest it thoroughly.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

pepov commented 1 month ago

@sebastiendejou or anyone else still have any interest in trying gracefulReload? If yes we can implement a flag for that.