kube-logging / logging-operator

Logging operator for Kubernetes
https://kube-logging.dev
Apache License 2.0
1.54k stars 329 forks source link

ImagePullSecrets for config-reload not used #880

Closed skaffille closed 2 years ago

skaffille commented 2 years ago

Describe the bug: We have a private container registry, which is the only registry we are allowed to pull certain images from. We provided the imagePullSecrets configuration for fluentd.configReloaderImage on the logging CRD and installed it with the logging operator 3.15.0.

For fluentbit the imagePullSecrets configuration is reflected in the DaemonSet ...

Expected behaviour: The statefulset for the fluentd has the corresponding imagePullSecret set and the image can be pulled from a private registry

Steps to reproduce the bug: Use a private registry for the required containers. Configure a secret to pull those images from the registry. Create a logging configuration referencing the secret. Install the logging configuration.

Additional context: Add any other context about the problem here.

Environment details:

/kind bug

ahma commented 2 years ago

Hi @skaffille! First of all sorry for the delay, and thanks for the report. I've just checked the code, and it looks like the fluend's imagePullSecrets is used all of the statefulset's containers (inc, reloader). Could you please check this in your env? Thanks.