search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
20 stars 22 forks source link

delete k8s resources after Delete/Revoke and set ownerReference for secret and CM #115

Closed jeffvance closed 5 years ago

jeffvance commented 5 years ago

Main purposes of this PR are:

  1. move k8s cleanup code to after the Delete() and Revoke() calls so that:
    • certain provisioners (ceph) can access the generated secret in their Delete/Revoke methods.
    • it's more obvious that the lib was unable to complete the Delete/Revoke.
  2. add ownerReferences to the generated CM and Secret and remove explicit delete calls from lib.

Signed-off-by: jeffvance jeff.h.vance@gmail.com

cc. @copejon

jeffvance commented 5 years ago

TODO: check design doc to make sure OwnerReferences are shown and Delete/Revoke are describes correctl in terms of when k8s resources are deleted. @jeffvance