search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
20 stars 22 forks source link

Bump kubernetes version to 14.1 #136

Closed rohantmp closed 5 years ago

rohantmp commented 5 years ago

Rook is being bumped to 1.14.1, but it can't update until this is bumped to 1.14.1 as it imports this.

I had previously said:

Can we please merge this into a 1.14.1 branch so that merging this doesn't break rook and then when rook updates it can point to the 1.14.1 branch.

That is the only safe update strategy I can think of...

@travisn @leseb @copejon

This turned out to nonsense and handled by Gopkg.lock

Signed-off-by: Rohan CJ rohantmp@gmail.com

rohantmp commented 5 years ago

Please merge this rook is planning to update to kube1.14.1 and it is blocked by this @copejon

guymguym commented 5 years ago

@rohantmp We want to support OCP 3.11. Does this prevent it?

guymguym commented 5 years ago

Oh, just noticed that this was already 1.14.0 before your PR. But will that be a problem on OCP 3 (kube 1.13)? I don't know if this library uses any API's that are specific to 1.14 and not 1.13...

rohantmp commented 5 years ago

I think that it will be fine based on: https://kubernetes.io/docs/setup/release/version-skew-policy/

Maybe one thing to keep an eye out for would be deprecated api versions (Eg: alpha of some resource no longer available), but that seems like it won't be a problem as far as updating the libraries goes.

https://kubernetes.io/docs/reference/using-api/deprecation-policy/

travisn commented 5 years ago

As @rohantmp mentioned, the compatibility matrix is good with the K8s client. We've been on the K8s 1.14 client in Rook for a few months and haven't had any reported issues connecting down to K8s 1.10 (currently the lowest supported rook version).

rohantmp commented 5 years ago

@guymguym can we merge this?

guymguym commented 5 years ago

Yes of course!