Closed guymguym closed 4 years ago
Another question - I saw you listed Gopkg.lock in gitignore. I don't think this is the recommended way. Was there a problem with it?
Another question - I saw you listed Gopkg.lock in gitignore.
I think this is an artifact of dependency resolution from a while back. Re-reading dep docs, it still says that Gopkg.lock is ignored in dependencies of projects (i.e. the lib), so un-ignoring it should be safe.
According to the dep author, it's safe and should always be done: https://github.com/golang/dep/issues/208
go test ./pkg/... is failing on CI. Did it work for you?
The tests are stale. The ownerRef is causing the failures here - the want
object leaves it nil but the returned OBC contains one. I already addressed this #140 , will extract those changes and open a PR to this branch so it'll go in with the CI fixes.
So should this pr also not hide _Gopkgg.lock?
@copejon @jeffvance
go test ./pkg/...
is failing on CI. Did it work for you?