search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
21 stars 22 forks source link

fix typo/formatting from pr 141 #147

Closed jeffvance closed 5 years ago

jeffvance commented 5 years ago

Fixes a typo and code generation format issues from pr #141 After 141 was merged hack/update-codegen.sh failed with this error:

$ hack/update-codegen.sh 
Generating deepcopy funcs
F0904 17:16:10.434242    8135 main.go:82] Error: Failed executing generator: some packages had errors:
type "k8s.io/apimachinery/pkg/runtime.Object2" in k8s:deepcopy-gen:interfaces tag of type k8s.io/apimachinery/pkg/runtime.Object2 is not an interface, but: ""

This was due to the Object2 typo. But also the format of the gen tags didn't match the pattern expected by codegen

Signed-off-by: jeffvance jeff.h.vance@gmail.com

@copejon @guymguym

guymguym commented 5 years ago

@jeffvance @copejon Whoops. Sorry about that - that was a nasty typo by me. Thanks for the quick fix 👍