search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
20 stars 22 forks source link

tracking - go.sh vet imports results #154

Open screeley44 opened 5 years ago

screeley44 commented 5 years ago

For tracking adding results of vet imports:

[screeley@screeley lib-bucket-provisioner (gosh)]$ ./hack/go.sh vet imports
--------  vetting
# k8s.io/client-go/rest
../../../../pkg/mod/k8s.io/client-go@v11.0.0+incompatible/rest/request.go:598:31: not enough arguments in call to watch.NewStreamWatcher
    have (*versioned.Decoder)
    want (watch.Decoder, watch.Reporter)
--------  formatting
goimports -w -local sigs.k8s.io/controller-runtime,github.com/kube-object-storage/lib-bucket-provisioner/ for packages under /home/screeley/git/go/src/github.com/kube-object-storage/lib-bucket-provisioner/pkg/apis/objectbucket.io
goimports -w -local sigs.k8s.io/controller-runtime,github.com/kube-object-storage/lib-bucket-provisioner/ for packages under /home/screeley/git/go/src/github.com/kube-object-storage/lib-bucket-provisioner/pkg/apis/objectbucket.io/v1alpha1
goimports -w -local sigs.k8s.io/controller-runtime,github.com/kube-object-storage/lib-bucket-provisioner/ for packages under /home/screeley/git/go/src/github.com/kube-object-storage/lib-bucket-provisioner/pkg/provisioner
goimports -w -local sigs.k8s.io/controller-runtime,github.com/kube-object-storage/lib-bucket-provisioner/ for packages under /home/screeley/git/go/src/github.com/kube-object-storage/lib-bucket-provisioner/pkg/provisioner/api
goimports -w -local sigs.k8s.io/controller-runtime,github.com/kube-object-storage/lib-bucket-provisioner/ for packages under /home/screeley/git/go/src/github.com/kube-object-storage/lib-bucket-provisioner/pkg/provisioner/api/errors
[screeley@screeley lib-bucket-provisioner (gosh)]$ git status
# On branch gosh
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#   modified:   pkg/apis/objectbucket.io/register.go
#   modified:   pkg/apis/objectbucket.io/v1alpha1/doc.go
#   modified:   pkg/apis/objectbucket.io/v1alpha1/objectbucket_types.go
#   modified:   pkg/apis/objectbucket.io/v1alpha1/objectbucket_types_test.go
#   modified:   pkg/apis/objectbucket.io/v1alpha1/register.go
#   modified:   pkg/provisioner/api/domain.go
#   modified:   pkg/provisioner/api/errors/errors.go
#   modified:   pkg/provisioner/api/provisioner.go
#   modified:   pkg/provisioner/controller.go
#   modified:   pkg/provisioner/fakeinterface_test.go
#   modified:   pkg/provisioner/helpers.go
#   modified:   pkg/provisioner/helpers_test.go
#   modified:   pkg/provisioner/log.go
#   modified:   pkg/provisioner/manager.go
copejon commented 5 years ago

The imports changes isn't surprising.

The vet error looks like a result of having go mods enabled. What happens when you set GO111MODULES=off.

guymguym commented 5 years ago

GO111MODULES is a mysterious env, I can't even imagine what would happen...

screeley44 commented 5 years ago

same @copejon