search

kube-object-storage / lib-bucket-provisioner

Library for the dynamic provisioning of object store buckets to be used by object store providers.
Apache License 2.0
21 stars 22 forks source link

Support setting OwnerReferences on OB,Secret,CM to handle deletion when deleting the provisioner #172

Open guymguym opened 5 years ago

guymguym commented 5 years ago

We want to handle the case where we are uninstalling the provisioner while OBC/OBs already exist for applications.

I think the desired behavior is that existing OBs will get deleted and the OBCs will change their status to represent a no-provisioner phase.

jeffvance commented 5 years ago

I think the desired behavior is that existing OBs will get deleted and the OBCs will change their status to represent a no-provisioner phase.

This seems reasonable.

jeffvance commented 5 years ago

I propose a change to the title since OBs, Secrets and CMs already have ownerReference set.

copejon commented 5 years ago

The OBs are a little ~trickier~ tricky. Cluster-scoped dependents can only specify cluster-scoped owners, but not namespace-scoped owners..

jeffvance commented 5 years ago

The OBs are a little trickier.

Good point! I forget ownerRefs cannot be applied to non-namespaced resources.